fix: validate inputs when passing both async and defer #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Tempted to say I'm leaning toward silent ignoring over throwing but I can't say I have a good reason other than that this was designed to follow the web standard attributes for script tags and I don't think it's not allowed to add both. Somehow silent ignoring of async feels more in line with this to me. (But not feeling really strongly about this)
wkillerud
force-pushed
the
no-async-and-defer
branch
from
d9df686 to
d3a73a3
Compare
digitalsadhu
approved these changes
Jan 31, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
## [5.0.2](v5.0.1...v5.0.2) (2024-02-01) ### Bug Fixes * validate inputs when passing both async and defer ([#226](#226)) ([dfb40d6](dfb40d6))
|
🎉 This PR is included in version 5.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leads to unexpected results. An option is to ignore
asyncsilently if passingdefer: true, since this could start breaking things.