fix: Simplify js and css value validation #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Jul 15, 2020
# [5.0.0-next.2](v5.0.0-next.1...v5.0.0-next.2) (2020-07-15) ### Bug Fixes * Simplify js and css value validation ([#70](#70)) ([05a1ffc](05a1ffc))
|
🎉 This PR is included in version 5.0.0-next.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
# [5.0.0](v4.5.1...v5.0.0) (2023-11-28) ### Bug Fixes * Improve ESM exports to account for dual module exports ([#123](#123)) ([42ebb4f](42ebb4f)) * Point require export to main.js ([#122](#122)) ([1438ee6](1438ee6)) * Remove original url module ([#185](#185)) ([6c01c0f](6c01c0f)) * Simplify js and css value validation ([#70](#70)) ([05a1ffc](05a1ffc)) ### Features * Convert to ESM ([#119](#119)) ([349c5b9](349c5b9)) * Drop node 10.x support ([#67](#67)) ([84203f8](84203f8)) * Remove CJS build step ([#170](#170)) ([15390ed](15390ed)) * Use ES private properties instead of Symbols for privacy ([#72](#72)) ([4083fa1](4083fa1)) ### BREAKING CHANGES * Convert from CommonJS to ESM * feat: convert to ESM * fix: Remove outcommented code * ci: Add build step for backward compat to CJS * ci: Ignore linting dist directory Co-authored-by: Trygve Lie <trygve.lie@finn.no> * Due to dropping node 10.x support we use ES private properties instead of Symbols. We've been using Symbols to define private properties in classes up until now. This has the downside that they are not true private and in later versions of node.js one would see these Symbols when inspecting an object. What we want is proper private properties. This PR does also add a pretty printer which outputs an object literal or the object so when debugging one can see the getters and setters of the object. Example: printing a object with `console.log()` would previously print the following: ```sh PodiumHttpIncoming { [Symbol(podium:httpincoming:development)]: false, [Symbol(podium:httpincoming:response)]: {}, [Symbol(podium:httpincoming:request)]: {}, [Symbol(podium:httpincoming:context)]: {}, [Symbol(podium:httpincoming:params)]: {}, [Symbol(podium:httpincoming:proxy)]: false, [Symbol(podium:httpincoming:name)]: '', [Symbol(podium:httpincoming:view)]: {}, [Symbol(podium:httpincoming:url)]: {}, [Symbol(podium:httpincoming:css)]: [], [Symbol(podium:httpincoming:js)]: [] } ``` Now the following will be printed: ```sh { development: false, response: {}, request: {}, context: {}, params: {}, proxy: false, name: '', view: {}, url: {}, css: [], js: [] } ``` Co-authored-by: Trygve Lie <trygve.lie@finn.no> * Only support node 12 and 14. Co-authored-by: Trygve Lie <trygve.lie@finn.no>
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not really make any sense using the json schema to validate the
valueargument of a JS and CSS object. The schema is intended to validate the whole object and not just one single value. Due to this the validation of thevalueargument of a JS and CSS object is simplified.The schema is updated to use version 5.0.0-next.1 and tests to validate a JS and CSS object with the schema is added.