Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSR doesn't work for i18n #37

Closed
kachar opened this issue Feb 16, 2021 · 3 comments · Fixed by #78
Closed

SSR doesn't work for i18n #37

kachar opened this issue Feb 16, 2021 · 3 comments · Fixed by #78
Assignees
@StanislavSt
Labels
type: bug Something isn't working

Comments

@kachar
Copy link
Member

kachar commented Feb 16, 2021

The server renders plain non-translated objects on first request. Then the client renders the i18n which causes a flicker

<title>nav.login</title>
@kachar kachar added the type: bug Something isn't working label Feb 16, 2021
@kachar
Copy link
Member Author

kachar commented Feb 22, 2021 •
edited
Loading

Waiting for the i18n + next.js 10 to be supported after i18next/next-i18next#869 is closed or released in beta

@kachar
Copy link
Member Author

kachar commented Feb 24, 2021

There's a new beta of next-18next we we might bump this task up

https://github.com/isaachinman/next-i18next/blob/2640dc4fc1234b286e7b690bcb338c23329c0438/README.md

@StanislavSt
Copy link
Member

StanislavSt commented Feb 26, 2021 •
edited
Loading

@kachar Looks like next-i18next v8.0.0 is out - https://github.com/isaachinman/next-i18next/releases/tag/v8.0.0.
Time to fix this bug ? I could test it tonight.

@StanislavSt StanislavSt mentioned this issue Feb 26, 2021
Merged
@kachar kachar closed this as completed in #78 Mar 2, 2021
kachar added a commit that referenced this issue Mar 2, 2021
@kachar
Merge pull request #78 from daritelska-platforma/bug-37-i18n-ssr
8fdd19e 
#37 SSR doesn't work for i18n
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StanislavSt StanislavSt

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#37 SSR doesn't work for i18n podkrepi-bg/frontend
2 participants
@kachar @StanislavSt