Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UI improvements on Homepage #1423

Merged
merged 10 commits into from
May 3, 2023
Merged

Add UI improvements on Homepage #1423

merged 10 commits into from
May 3, 2023

Conversation

ani-kalpachka
Copy link
Member

@ani-kalpachka ani-kalpachka commented May 2, 2023 •
edited
Loading

  • Update Statistics section for mobile:
Before After
0 1
  • Update Statistics section for desktop:
Before After
image image
  • Updated Support section text on mobile:
Before After
0 1
  • Removed whitespace above Active campaigns section on mobile:
Before After
0 1

  • Update Completed carousel dots colors and spacings in order to match design:
    image

  • Updates spacings.

@ani-kalpachka ani-kalpachka changed the title Update tatistics on homepage Update Statistics on Homepage (UI) May 2, 2023
@ani-kalpachka ani-kalpachka marked this pull request as ready for review May 2, 2023 08:58
@ani-kalpachka ani-kalpachka changed the title Update Statistics on Homepage (UI) Add UI improvements on Homepage May 2, 2023
@slavcho
Copy link
Contributor

slavcho commented May 2, 2023

Looks good to me.
I personally vote for removing the decimal digits from the money (on both campaigns listing page and in the stats).

image

This seems too much. We either put is as 10055.22 or 10052+, 10055.22+ is an overkill imho.
( I can go even further with the 93+ 😀, but lets leave this to the design team. )

@ani-kalpachka
Copy link
Member Author

@slavcho Thank you for the review!
I have concerns about decimal digits too. I suggest we discuss with team on which components to remove them and on which to save them and update this as a separate issue.

mm-hstefanova
mm-hstefanova reviewed May 3, 2023
View reviewed changes
Copy link
Contributor

@mm-hstefanova mm-hstefanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me as well

@igoychev igoychev added the run tests Allows running the tests workflows for forked repos label May 3, 2023
@ani-kalpachka
Copy link
Member Author

Update: The + sign is removed:
image

@ani-kalpachka ani-kalpachka merged commit 1cf4594 into master May 3, 2023
@ani-kalpachka ani-kalpachka deleted the update-statistics-on-homepage branch May 3, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mm-hstefanova mm-hstefanova mm-hstefanova left review comments

@igoychev igoychev igoychev approved these changes

Assignees
No one assigned
Labels
area: frontend run tests Allows running the tests workflows for forked repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ani-kalpachka @slavcho @igoychev @mm-hstefanova