Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning when link_with(x) is used without depends_on(x) if x is in local tree #2

Open
podusowski opened this issue Mar 21, 2015 · 2 comments

Comments

@podusowski
Copy link
Owner

To link with internal lib you have to write:

target application app link_with(some_local_library pthread) depends_on(some_local_library)

now, we have to options to avoid potential errors when someone forgets about depends_on attribute: make it implicit when link_with elements are in the tree, or give a warning when it is but depends_on is not there.

@salwator
Copy link
Collaborator

Why not auto-link with everything target depends on?

@podusowski
Copy link
Owner Author

Because you can depend on something which is not a library, for example, in rusted I have 2 app targets: Server and ServerSCT which depends on it, ServerSCT also depends on some phonys which generate sqlite db (those can be C++ generators or anything else in that matter). Too many cases would not be covered this way, besides, I think it's better to depends_on than link something implicitly.

podusowski added a commit that referenced this issue Apr 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants