[ENHANCEMENT] Open android project command #14 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| projectPath = path.join(project.root, 'cordova', 'platforms/ios/*.xcodeproj'); | ||
| } else if (platform === 'android') { | ||
| projectPath = path.join(project.root, 'cordova', 'platforms/android/.project'); | ||
| } |
There was a problem hiding this comment.
Could you provide an else here that throws an error informing the user that the platform they specified isn't supported? Rather than throwing, if you reject with an error it should propagate up and be displayed to the user. Please also add a test for that
|
so i cant "reject", since the promise variables aren't defined in the command. But i can throw Error("Unsupported platform"), but when i do that it doesn't enter the assert block in the test. And it displays the error in terminal with a stack trace |
|
@billybonks I just created a PR to your branch with some changes. Mostly more testing, but also this promise thing. If you merge that then I think this g2g |
per platform testing of open command and reject unsupported platform
jakecraige
added a commit
that referenced
this pull request
Oct 23, 2014
[ENHANCEMENT] Open android project command #14
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.