Fix BaseParser + more TLD parsers #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
pogzyb
commented
Feb 12, 2021
pogzyb
commented
- Fixed bug that was causing BaseParser's reg_expressions to be updated to empty dict
- Added more TLD parsers
- Changed exception Class names / added base exception
The 'WhoIs' error classes were renamed for clarity. The doc strings of the exposed package functions were updated.
Added a number of top level domain parsers. Fixed a bug in BaseParser, which wasn't allowing a non-supported TLD to be parsed anyway. Ran PyCharm's code formatting to remove extra blankspaces.
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
+ Coverage 77.06% 79.05% +1.98%
==========================================
Files 6 6
Lines 1051 1160 +109
==========================================
+ Hits 810 917 +107
- Misses 241 243 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.