Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User notification client fixes #174

Merged

Conversation

tplaymeow
Copy link
Contributor

  • bc9ad36 Fixed delegate object deallocating. A similar solution is used in StoreKitClient.

    let stream = AsyncThrowingStream<ProductsResponse, Error> { continuation in
    let request = SKProductsRequest(productIdentifiers: products)
    let delegate = ProductRequest(continuation: continuation)
    request.delegate = delegate
    request.start()
    continuation.onTermination = { [request = UncheckedSendable(request)] _ in
    request.value.cancel()
    _ = delegate
    }
    }

  • 5e73c92 According to the documentation, delegate object must be assigned to UNUserNotificationCenter before app finishes launching.

Copy link
Member

@mbrandonw mbrandonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great finds, thanks!

@christinecase02

This comment was marked as spam.

@stephencelis stephencelis merged commit ed59ba8 into pointfreeco:main Aug 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants