Settings Dependency + Navigation Finesse #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
added a commit
that referenced
this pull request
Aug 23, 2023
* Use built-in Reducer.onChange * wip * wip * update stats * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * fix * wip * Settings Dependency + Navigation Finesse (#186) * Beginnings of the UserSettingsClient. * extracted UserSettingsClient to its own library * Decoupled haptics settings from some features. * Stopped threading isAnimationReduced state through multple features and fixed tests. * Stopped threading isAnimationReduced to leaderboard. * Moved daily challenge settings into UserSettings. * Moved enableNotifications to UserSettings. * Moved developer settings to app storage. * Game feature has its own settings, haven't deleted home settings yet. * Removed GameFeature * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * Fixed some runtime warnings. * wip * Flatten nag banner domains, remove old settings from home * wip * wip --------- Co-authored-by: Brandon Williams <mbrandonw@hey.com> --------- Co-authored-by: Brandon Williams <mbrandonw@hey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds off #185. It's a big one!
Settings Dependency
First, we did a refactor we've been wanting to do for a long time. isowords' domain has held onto non-optional
Settings.Stateand has shared this state through various computed properties. This meant introducing a bunch of awkward domains and transformation to make settings available to various features. This pattern is an extension of the "shared state" case study we originally shipped alongside the Composable Architecture. While the pattern is interesting, it introduces a bunch of boilerplate that is difficult to maintain over time and as a project grows.Since first exploring this pattern of shared/computed state we have come to the conclusion that shared state should come from a dependency instead, and then features that need access to this state can simply ask the dependency for it. And in this case it means pushing
UserSettingsinto aUserSettingsClientthat can be queried, updated, and subscribed to. Moving this state into a dependency means all settings screens can be simple, optional presentations rather than contortions of sharing the same non-optional state.Navigation Finesse
With settings as a dependency, we were able to remove some extra domains in the app, most notably the
GameFeature, which was simply a computed part of state that made settings available to the game feature. The game can now present settings directly, home can present the game directly, and features can more reliably request dismissal rather than rely on delegates to do the job manually.