Support for RTL layout testing with Xcode 11 test plans #262
Conversation
…nment variable is available
|
@mbrandonw @stephencelis Hi! Over a month passed since I opened this PR. Is there any chance to merge it or give any pointers / suggestions |
|
Hey @SebastianOsinski! It'd definitely be nice to add an environment component to test names to distinguish things like Xcode 11 test plans! @mbrandonw and I will thing things over and bike-shed the variable name and where it renders in the filename soon. |
|
@stephencelis Hi! Did you have time to think it over? I'm always ready to update this PR according to your suggestions ;) |
| @@ -11,6 +11,12 @@ import UIKit | |||
| import WebKit | |||
| #endif | |||
|
|
|||
| // Explanation for not providing `layoutDirection` trait in base traits for devices: | |||
| // .init(layoutDirection: .leftToRight) is commented out because of http://www.openradar.me/radar?id=5044259694575616 | |||
| // When tests are ran with RTL language (e.g. Arabic), this override does not fully change layout to LTR (due to issue linked above) | |||
There was a problem hiding this comment.
Typo, should be does not fully change layout to RTL
|
Do we have any update on this PR? My team is working on a test project and we highly anticipate this feature. Thanks all for the help! |
|
bump on this PR |
This PR adds support for
SNAPSHOT_CONFIGURATION_NAMEenvironment variable which can be used in Test Plans configurations. When aforementioned variable exists, another level of directory nesting is added to store separate snapshots for each configuration.Additionally, to fully support RTL layout testing,
.leftToRighttraits have been removed frombasetrait sets for each snapshotting device. This trait override caused RTL UIs to not be correctly rendered (see http://www.openradar.me/radar?id=5044259694575616).See #168 for more background for this PR.