Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Added DFN-8-1EP_4x4mm_P0.8mm_EP2.3x3.24mm #431

Merged
merged 4 commits into from
Sep 28, 2019
Merged

Added DFN-8-1EP_4x4mm_P0.8mm_EP2.3x3.24mm #431

merged 4 commits into from
Sep 28, 2019

Conversation

JeppeSRC
Copy link
Contributor

@codeclimate
Copy link

codeclimate bot commented Sep 22, 2019

Code Climate has analyzed commit a6e4426 and detected 0 issues on this pull request.

View more on Code Climate.

maximum: 0.6

EP_size_x: 2.30
EP_size_y: 3.24
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enter size of the package ep with this parameter and use EP_size_x_overwrite to force it to use the pad size as defined in the datasheets suggested footprint. (same with y size)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I made the changes but the EP didn't get overridden. Or did I fuck up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is it because I'm trying to force the EP to be bigger than the maximum?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a typo in the parameter name.

nominal: 3
maximum: 3.23

EP_size_x_override: 2.30
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EP_size_x_override should be EP_size_x_overwrite

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that explains it. 🤦‍♂

@poeschlr
Copy link
Collaborator

thanks

@poeschlr poeschlr merged commit 0539645 into pointhi:master Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants