Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue — change private static $_default_breakpoints from 'lg' => 1024 to 'lg' => 1025 #1454

Closed
Githubhem opened this issue Mar 13, 2017 · 3 comments

Comments

@Githubhem
Copy link

Githubhem commented Mar 13, 2017

Hello!

You should change private static $_default_breakpoints from 'lg' => 1024 to 'lg' => 1025.
Now its 1024 and we have @media(max-width:1023px) for tablet, but we must have @media(max-width:1024px) for tablet.

includes/responsive.php 

private static $_default_breakpoints = [
		'xs' => 0,
		'sm' => 480,
		'md' => 768,
		'lg' => 1025,
	];

If you change private static $_default_breakpoints from 'lg' => 1024 to 'lg' => 1025 — all new pages will be working right — @media(max-width:1024px) for tablet.

Old pages still be @media(max-width:1023px). We must go to Elementor Tools and Regenerate CSS.

@arielk
Copy link
Member

arielk commented Mar 14, 2017

This is something that fixed in the past. Where do you see the that we use a width of 1023px?

@Githubhem
Copy link
Author

Elementor uses 1023px in @media(max-width:1023px) for tablet. But must be @media(max-width:1024px). Here: http://relfy.ru

1023

It happens because private static $_default_breakpoints = ['lg' => 1024,]; (responsive.php ).
Tablet "md" max = lg-1 ($screen-md-max: map_get($breakpoints, lg) - 1;)
And we have: 1024-1=1023 px.

If you change private static $_default_breakpoints from 'lg' => 1024 to 'lg' => 1025 — all new pages will be working right — @media(max-width:1024px) for tablet (1025 px -1 = 1024 px). Old pages still be @media(max-width:1023px). We must go to Elementor Tools and Regenerate CSS.

@arielk
Copy link
Member

arielk commented Mar 15, 2017

Fixed for the next version. Thanks for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants