Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchor links smooth scrolling not working when admin bar is disabled #2210

Closed
johnnyluu opened this issue Aug 18, 2017 · 1 comment
Closed

Comments

@johnnyluu
Copy link

The anchor link smooth scroll breaks when the admin bar is disabled because in your frontend.js, you check the admin bar's height. If admin bar doesn't exist, the height() returns null, and the calculated scrollTop is NaN. Adding a default 0 for when admin bar doesn't exist of checking if admin bar exists would fix this.

@KingYes
Copy link
Member

KingYes commented Aug 20, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants