Attempt to fix aws/ec2 with :filters parameter #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtenny
reviewed
Jun 5, 2023
| @@ -66,7 +66,8 @@ | |||
| append (to-query-params k v))) | |||
| (loop for i from 1 | |||
| for v in value | |||
| collect (cons (format nil "~A.member.~A" key i) v)))) | |||
| append (to-query-params (format nil "~A.member.~A" key i) | |||
| (aws-sdk/generator/shape::input-params v))))) | |||
There was a problem hiding this comment.
FYI, tried this, (though my quicklisp dist of aws-sdk is apparently behind the version edited here). I now get as far as making the request but get a 400 response saying "The parameter Filters is not recognized".
This is on the stack, may indicate the malformed request. Not having done much at the request level I can't say if it's valid, though I'm thinking it's supposed to be Filter.N, not Filter.member.N.
#<QURI.URI.HTTP:URI-HTTPS https://ec2.us-east-1.amazonaws.com/?Action=DescribeInstances&Version=2016-11-15&Filters.member.1.Name=tag%3AName&Filters.member.1.Values.member.1=dev-19587>
There was a problem hiding this comment.
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeInstances.html - though I haven't checked if that is the version being used by aws-sdk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably fixes #30
Disclaimer: I'm not sure at all that it fixes the issue - I don't have enough knowledge to be sure that it doesn't break anything, and I don't even know how to test if this works properly - I don't use aws.
Still, I hope that it is a correct fix or it will be at least useful.