Force auth if refresh fails #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getkey
requested changes
Oct 6, 2021
| config = JSON.parse(readFileSync(configPath, 'ascii')) | ||
| } catch (e) { | ||
| // Ignore. | ||
| if (!force) { |
There was a problem hiding this comment.
I would split out a function fetchAuthFromP4d. It would allow expressing this more elegantly/explicitly, not relying on config === undefined in the check below. Rather, you could call it right away if force === false
There was a problem hiding this comment.
Lets keep this for a slightly bigger refactor.
ErikSom
approved these changes
Oct 7, 2021
erikdubbelboer
added a commit
that referenced
this pull request
Oct 21, 2021
Bring back #5 which was somehow reverted after the typescript rewrite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a refresh fails we should try the normal auth flow again.