Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust, python): fix int/float downcast in is_in #10620

Merged
merged 3 commits into from Aug 20, 2023
Merged

fix(rust, python): fix int/float downcast in is_in #10620

merged 3 commits into from Aug 20, 2023

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Aug 20, 2023 •
edited

fixes #9070

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Aug 20, 2023
@ritchie46 ritchie46 merged commit 046588f into main Aug 20, 2023
24 checks passed
@ritchie46 ritchie46 deleted the is_in_int branch August 20, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego Awaiting requested review from stinodego stinodego is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

is_in returns True for int/float where it shouldn't, e.g. [5].is_in[5.8].
1 participant
@ritchie46