feat(rust, python): is_first also supports numeric list type. #10727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reswqa
requested review from
ritchie46,
stinodego,
alexander-beedie and
orlp
as code owners
github-actions
bot
added
enhancement
reswqa
commented
Aug 25, 2023
| @@ -97,6 +113,11 @@ pub fn is_first(s: &Series) -> PolarsResult<BooleanChunked> { | |||
| }, | |||
| #[cfg(feature = "dtype-struct")] | |||
| Struct(_) => return is_first_struct(&s), | |||
| #[cfg(feature = "group_by_list")] | |||
| List(inner) if inner.is_numeric() => { | |||
There was a problem hiding this comment.
if inner.is_numeric() here is for more friendly error message. If there is a List<Utf8> here, we will get InvalidOperationError: is_first operation not supported for dtype list[str] instead of ComputeError: "grouping on list type is only allowed if the inner type is numeric".
ritchie46
approved these changes
Aug 25, 2023
|
Looks good. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we already supported group_by
list<T> where T has a numeric physical type. I assume it is easy to impis_first.The title may be a bit misleading, as it refers to the physical type being numerical rather than logical. So it actually supports a wider range of types.