build(python): Set minimum version for pydantic to 2.0.0
#10923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stinodego
requested review from
ritchie46 and
alexander-beedie
as code owners
github-actions
bot
added
build
alexander-beedie
approved these changes
Sep 5, 2023
|
@stinodego would it be a lot of hassle to revert this and fix the tests? A lot of polars users were using patito and that is build around pydantic 1.0. |
|
No hassle, I'll revert this. We can require pydantic >= 2.0.0 in our dev dependencies to make our tests run. We don't necessarily need this for our main code base, I guess. I'll watch patito's progress on implementing pydantic v2, and re-add this version requirement when it's done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests don't run with the older version.