-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Improve rolling_median
algorithm
#12704
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
force-pushed
the
rolling_median
branch
from
November 28, 2023 19:53
7be1389
to
213af31
Compare
ritchie46
changed the title
WIP: improve rolling_median algorithm
perf: improve rolling_median algorithm
Dec 6, 2023
github-actions
bot
added
performance
Performance issues or improvements
python
Related to Python Polars
rust
Related to Rust Polars
labels
Dec 6, 2023
ritchie46
requested review from
stinodego,
alexander-beedie and
MarcoGorelli
as code owners
December 6, 2023 18:20
is documentation coming in this PR later on or it will some different PR? reading rust is not yet that fluent for me. I am interested about implementation used precisely. |
stinodego
changed the title
perf: improve rolling_median algorithm
perf: Improve Dec 15, 2023
rolling_median
algorithm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
performance
Performance issues or improvements
python
Related to Python Polars
rust
Related to Rust Polars
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes quadratic worst case to O(nlogk).
closes #12609
0.19.x
PR