Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(python)!: Update constructors for Array and Decimal #12837

Merged
merged 2 commits into from
Dec 1, 2023
Merged

feat(python)!: Update constructors for Array and Decimal #12837

merged 2 commits into from
Dec 1, 2023

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Dec 1, 2023 •
edited
Loading

Note

This is an accellerated breaking change because the intended usage could not be introduced without breaking the previous usage.

Changes

  • Switches around the parameters for both Decimal and Array:
    • Decimal(scale, precision) => Decimal(precision, scale)
    • Array(width, inner) => Array(inner, width)

@github-actions github-actions bot added breaking Change that breaks backwards compatibility enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Dec 1, 2023
@stinodego stinodego marked this pull request as ready for review December 1, 2023 15:02
@stinodego stinodego merged commit c380eb9 into main Dec 1, 2023
20 checks passed
@stinodego stinodego deleted the breaking-dtype-init branch December 1, 2023 15:14
@c-peters c-peters added the accepted Ready for implementation label Dec 1, 2023
@alexander-beedie alexander-beedie mentioned this pull request Dec 1, 2023
Merged
@alexander-beedie alexander-beedie added the A-dtype-decimal Area: decimal data type label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

Assignees

@stinodego stinodego

Labels
A-dtype-decimal Area: decimal data type accepted Ready for implementation breaking Change that breaks backwards compatibility enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stinodego @alexander-beedie @c-peters