feat: make python map_batches
safer
#13181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will default to a safer version of
map_batches
. We will now assume you cannot run on batches. E.g. don't merely do an elementwise operation like+
orpow
, but do something that requires all data. E.g.sort
,sum
,rolling_min
, etc.map_batches
will now not run by default on the streaming engine unless you setis_elementwise=True
. In that case it can produce wrong results in a group-by, but hey, you said it was elementwise. 🤷