refactor(rust!): Rename Utf8 data type to String
#13224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
breaking rust
stinodego
force-pushed
the
utf8-to-string
branch
from
ae92581
to
7f67c78
Compare
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
orlp and
universalmind303
as code owners
It is unrelated though. ^^ |
stinodego
force-pushed
the
utf8-to-string
branch
from
3be7dcc
to
965e169
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares a future update where the
Stringdatatype may have a different representation than the standard arrow Utf8 format.This is just the Rust side. It also renames related functionality like
Utf8Chunked,AnyValue::Utf8, etc.Obviously, no functional changes.
The Arrow data types are not renamed.
ArrowDataType::Utf8,Utf8Array, etc. all remain the same.On the Python side, we will add
Stringand keepUtf8as an alias. I will do this in a separate PR as it is a bit more delicate to make sure the alias works correctly.