fix: Fix bug where rolling operations were ignoring check_sorted in some cases
#15227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
no-unnecessary-check-sorted-error
branch
from
b8c27b2
to
a6d3009
Compare
MarcoGorelli
force-pushed
the
no-unnecessary-check-sorted-error
branch
from
a6d3009
to
df4ae62
Compare
MarcoGorelli
commented
Mar 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15227 +/- ##
=======================================
Coverage 81.26% 81.27%
=======================================
Files 1355 1355
Lines 175676 175676
Branches 2518 2518
=======================================
+ Hits 142761 142774 +13
+ Misses 32434 32421 -13
Partials 481 481 ☔ View full report in Codecov by Sentry. |
MarcoGorelli
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie and
orlp
as code owners
stinodego
changed the title
check_sorted in some cases
github-actions
bot
added
fix
ritchie46
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #15225