Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle null index correctly for list take #15737

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

reswqa
Copy link
Collaborator

@reswqa reswqa commented Apr 18, 2024

This fixes #15719.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Apr 18, 2024
.iter()
.map(|index| {
Copy link
Collaborator Author

@reswqa reswqa Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this element in IdxArr is None, then it's value(i.e. index here) can be any values.

@reswqa reswqa marked this pull request as ready for review April 18, 2024 12:10
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.35%. Comparing base (70b71da) to head (dd8c84c).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15737      +/-   ##
==========================================
+ Coverage   81.33%   81.35%   +0.01%     
==========================================
  Files        1374     1378       +4     
  Lines      176471   176582     +111     
  Branches     2544     2544              
==========================================
+ Hits       143539   143651     +112     
+ Misses      32450    32449       -1     
  Partials      482      482              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Apr 18, 2024

CodSpeed Performance Report

Merging #15737 will not alter performance

Comparing reswqa:list_take (dd8c84c) with main (2e9674e)

Summary

✅ 22 untouched benchmarks

@ritchie46
Copy link
Member

Thanks you @reswqa. On a true bug squatting spree. ;)

@ritchie46 ritchie46 merged commit 0c2783a into pola-rs:main Apr 19, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exploding a list of lists where all the entries are null leads to a PanicException
2 participants