fix: Fix casting decimal to decimal for high precision #16049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
stinodego
commented
May 4, 2024
Comment on lines
-15
to
-18
| let min_for_precision = 9_i128 | ||
| .saturating_pow(1 + to_precision as u32) | ||
| .saturating_neg(); | ||
| let max_for_precision = 9_i128.saturating_pow(1 + to_precision as u32); |
There was a problem hiding this comment.
It's pretty bizarre to me that someone wrote this logic. I guess the intention was to define the bounds as e.g. 999 for precision 3, but it completely misses that mark. Am I missing something?
stinodego
commented
May 4, 2024
| @@ -50,7 +50,7 @@ def test_modulo() -> None: | |||
| ("value", "sqltype", "prec_scale", "expected_value", "expected_dtype"), | |||
| [ | |||
| (64.5, "numeric", "(3,1)", D("64.5"), pl.Decimal(3, 1)), | |||
| (512.5, "decimal", "(3,1)", D("512.5"), pl.Decimal(3, 1)), | |||
There was a problem hiding this comment.
This should have failed. New logic properly causes this to fail.
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16049 +/- ##
==========================================
- Coverage 80.96% 80.96% -0.01%
==========================================
Files 1386 1386
Lines 178385 178383 -2
Branches 3060 3060
==========================================
- Hits 144438 144431 -7
- Misses 33460 33465 +5
Partials 487 487
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
stinodego
force-pushed
the
fix-decimal-cast
branch
from
f3449c3
to
4dbd338
Compare
CodSpeed Performance ReportMerging #16049 will improve performances by 24.72%Comparing Summary
Benchmarks breakdown
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16027