Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): Clippy Error for CPUID #16241

Merged
merged 1 commit into from
May 15, 2024

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@coastalwhite coastalwhite changed the title Fix: Clippy Error for CPUID fix(rust): Clippy Error for CPUID May 15, 2024
@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.84%. Comparing base (a34ca2c) to head (779e1b8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16241   +/-   ##
=======================================
  Coverage   80.83%   80.84%           
=======================================
  Files        1394     1394           
  Lines      180095   180095           
  Branches     2913     2913           
=======================================
+ Hits       145577   145590   +13     
+ Misses      34015    34002   -13     
  Partials      503      503           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 15, 2024

CodSpeed Performance Report

Merging #16241 will improve performances by 19.79%

Comparing coastalwhite:fix-cpuid-clippy (779e1b8) with main (a34ca2c)

Summary

⚡ 1 improvements
✅ 33 untouched benchmarks

Benchmarks breakdown

Benchmark main coastalwhite:fix-cpuid-clippy Change
test_tpch_q2 15.4 ms 12.9 ms +19.79%

@ritchie46 ritchie46 merged commit 0270ffa into pola-rs:main May 15, 2024
23 checks passed
@coastalwhite coastalwhite deleted the fix-cpuid-clippy branch May 15, 2024 14:48
MarcoGorelli pushed a commit to MarcoGorelli/polars that referenced this pull request May 15, 2024
@c-peters c-peters added the accepted Ready for implementation label May 21, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants