-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust): Add general metadata structure to ChunkedArray
#16399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
New feature or an improvement of an existing feature
rust
Related to Rust Polars
labels
May 22, 2024
coastalwhite
force-pushed
the
prim-array-metadata
branch
4 times, most recently
from
May 23, 2024 13:18
07eee91
to
2370526
Compare
coastalwhite
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
May 23, 2024 13:19
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16399 +/- ##
==========================================
- Coverage 81.53% 81.51% -0.02%
==========================================
Files 1410 1412 +2
Lines 185061 185222 +161
Branches 2982 2982
==========================================
+ Hits 150885 150988 +103
- Misses 33660 33718 +58
Partials 516 516 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
May 23, 2024
coastalwhite
force-pushed
the
prim-array-metadata
branch
from
May 24, 2024 10:42
2370526
to
d879533
Compare
coastalwhite
force-pushed
the
prim-array-metadata
branch
from
May 27, 2024 08:28
d879533
to
42ae8f4
Compare
ritchie46
approved these changes
May 28, 2024
Great one @coastalwhite |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accepted
Ready for implementation
enhancement
New feature or an improvement of an existing feature
rust
Related to Rust Polars
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a general
Metadata
structure to theChunkedArray
, which can be used to be better informed decisions during the runtime of the query. Currently, it is not always set or used perfectly, but it can be slowly incorperated.