test: re add tests for as_polars_df(<ArrowTabular>)

pola-rs · May 7, 2024 · 303ea0b · 303ea0b
1 parent 2fde92a
commit 303ea0b
Showing 1 changed file with 27 additions and 29 deletions.
diff --git a/tests/testthat/test-as_polars.R b/tests/testthat/test-as_polars.R
@@ -232,35 +232,33 @@ test_that("from arrow Table and ChunkedArray", {
     unname(as.list(at))
   )
 
-  # no rechunk no longer works
-  # expect_identical(
-  #   lapply(at$columns, \(x) length(as_polars_series.ChunkedArray(x, rechunk = FALSE)$chunk_lengths())),
-  #   lapply(at$columns, \(x) x$num_chunks)
-  # )
-  # expect_grepl_error(expect_identical(
-  #   lapply(at$columns, \(x) length(as_polars_series.ChunkedArray(x, rechunk = TRUE)$chunk_lengths())),
-  #   lapply(at$columns, \(x) x$num_chunks)
-  # ))
-  # expect_identical(
-  #   as_polars_df.ArrowTabular(at, rechunk = FALSE)$
-  #     select(pl$all()$map_batches(\(s) s$chunk_lengths()))$
-  #     to_list() |>
-  #     lapply(length) |>
-  #     unname(),
-  #   lapply(at$columns, \(x) x$num_chunks)
-  # )
-
-  # expect_identical(
-  #   as_polars_df.ArrowTabular(at, rechunk = TRUE)$
-  #     select(pl$all()$map_batches(\(s) s$chunk_lengths()))$
-  #     to_list() |>
-  #     lapply(length) |>
-  #     unname(),
-  #   lapply(at$columns, \(x) x$num_chunks)
-  # )
-
-
-  # #not supported yet
+  expect_identical(
+    lapply(at$columns, \(x) length(as_polars_series.ChunkedArray(x, rechunk = FALSE)$chunk_lengths())),
+    lapply(at$columns, \(x) x$num_chunks)
+  )
+  expect_grepl_error(expect_identical(
+    lapply(at$columns, \(x) length(as_polars_series.ChunkedArray(x, rechunk = TRUE)$chunk_lengths())),
+    lapply(at$columns, \(x) x$num_chunks)
+  ))
+  expect_identical(
+    as_polars_df.ArrowTabular(at, rechunk = FALSE)$
+      select(pl$all()$map_batches(\(s) s$chunk_lengths()))$
+      to_list() |>
+      lapply(length) |>
+      unname(),
+    lapply(at$columns, \(x) x$num_chunks)
+  )
+
+  expect_identical(
+    as_polars_df.ArrowTabular(at, rechunk = TRUE)$
+      select(pl$all()$map_batches(\(s) s$chunk_lengths()))$
+      to_list() |>
+      lapply(length) |>
+      unname(),
+    lapply(at$columns, \(x) x$num_chunks)
+  )
+
+  #not supported yet
   # #chunked data with factors
   l = list(
     df1 = data.frame(factor = factor(c("apple", "apple", "banana"))),