-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataFrame$tail() #103
DataFrame$tail() #103
Conversation
Hi @vincentarelbundock. Thank you so much for finding time for writing a translation :) This is pretty alright. I would take the PR as it is right now. I will add some suggestions in the review, I came to appreciate, when I wrote the later translations. |
Thanks for the hints. I think the latest commit resolves all outstanding issues. I still don't quite understand what is going on under the hood, but I'll try to translate a few other functions. Will open a separate PR for those. |
Error handling in rpolars: robj_to!: |
many thanks @vincentarelbundock for this excellent contribution :) |
Thanks for the merge and the info, this is very useful. |
* DataFrame$tail() * DataFrame_tail PR review
* DataFrame translations: No arguments * translate: DataFrame$reverse() * translation: DataFrame$slice() * typo in readme (#102) * DataFrame$tail() (#103) * DataFrame$tail() * DataFrame_tail PR review * merge conflict cruft * GroupBy translations * DataFrame$slice() optional arg * translation DataFrame.var() and .std() * DataFrame: null_count(), estimated_size() * docs * try to fix examples * patrick * patrick 2 * patrick 3 * patrick 4 * simplify basic LazyFrame methods * roxydocs for previous commit * add newline eof * simplify DataFrame .null_count .estimated_size * test .estimated_size() * NEWS * Revert "NEWS" This reverts commit 76b6964. * NEWS 2 * Revert "NEWS 2" This reverts commit 6c11a63. * test .null_count() on DataFrame and GroupBy --------- Co-authored-by: Etienne Bacher <52219252+etiennebacher@users.noreply.github.com> Co-authored-by: sorhawell <sorhawell@gmail.com>
This is a first attempt at a minimal commit. Is this the kind of contribution you would welcome? What should I do different to facilitate a merge?