Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: move to the latest polars #1117

Merged
merged 10 commits into from
May 30, 2024
Merged

feat!: move to the latest polars #1117

merged 10 commits into from
May 30, 2024

Conversation

eitsupi
Copy link
Collaborator

@eitsupi eitsupi commented May 29, 2024

Part of #1108, fix the panic from polars::pl$select(list(list(list(1)))).

It contains breaking changes.

@eitsupi

This comment was marked as resolved.

@eitsupi

This comment was marked as resolved.

@eitsupi eitsupi marked this pull request as ready for review May 30, 2024 13:17
@eitsupi
Copy link
Collaborator Author

eitsupi commented May 30, 2024

This includes a fix for a critical bug that affects other updates, so I will merge for now.

@eitsupi eitsupi merged commit d513415 into main May 30, 2024
22 of 25 checks passed
@eitsupi eitsupi deleted the edge-polars branch May 30, 2024 14:16
Copy link
Collaborator

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This includes a fix for a critical bug that affects other updates, so I will merge for now.

I'm ok with that, I'll have little time to dedicate to polars in the next week or so, so feel free to merge before approval for other PRs too if they are important.

I'm just adding some comments that you can fix in future PRs.

NEWS.md Show resolved Hide resolved
tests/testthat/test-expr_expr.R Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants