Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl glimpse #277

Merged
merged 7 commits into from
Jun 30, 2023
Merged

impl glimpse #277

merged 7 commits into from
Jun 30, 2023

Conversation

sorhawell
Copy link
Collaborator

@sorhawell sorhawell marked this pull request as ready for review June 29, 2023 14:56
etiennebacher
etiennebacher approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sorhawell, very minor comments on doc

NEWS.md Outdated Show resolved Hide resolved
R/dataframe__frame.R Outdated Show resolved Hide resolved
tests/testthat/_snaps/dataframe.md Outdated Show resolved Hide resolved
sorhawell and others added 2 commits June 30, 2023 14:39
@sorhawell
space between type and values
d0a35a6
@sorhawell @etiennebacher
Apply suggestions from code review
7bda0e5 
Co-authored-by: Etienne Bacher <52219252+etiennebacher@users.noreply.github.com>
@sorhawell sorhawell merged commit 71e2c91 into main Jun 30, 2023
@sorhawell sorhawell deleted the glimpse branch June 30, 2023 13:23
@etiennebacher etiennebacher mentioned this pull request Jul 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiennebacher etiennebacher etiennebacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sorhawell @etiennebacher