Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(NEWS): polish NEWS #296

Merged
merged 6 commits into from
Jul 3, 2023
Merged

docs(NEWS): polish NEWS #296

merged 6 commits into from
Jul 3, 2023

Conversation

eitsupi
Copy link
Collaborator

@eitsupi eitsupi commented Jul 3, 2023

Includes a fix to undo extendr-wrappers changes that was incorrectly updated by #268.

@eitsupi eitsupi added this to the 1st CRAN Release milestone Jul 3, 2023
Copy link
Collaborator

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this. I think that after this version is released, we should split the news in several categories like new functions or methods, bug fixes, docs, etc.

NEWS.md Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
Co-authored-by: Etienne Bacher <52219252+etiennebacher@users.noreply.github.com>
@eitsupi eitsupi merged commit 69cb807 into pola-rs:main Jul 3, 2023
@eitsupi eitsupi deleted the update-news branch July 3, 2023 16:33
@eitsupi
Copy link
Collaborator Author

eitsupi commented Jul 3, 2023

Interestingly, MkDocs material does not seem to support the level of listing?

In https://rpolars.github.io/NEWS/

image

In https://github.com/pola-rs/r-polars/blob/main/NEWS.md

image

@etiennebacher
Copy link
Collaborator

It might be needed to use a different symbol for each list level: https://squidfunk.github.io/mkdocs-material/reference/lists/?h=list#usage

@eitsupi
Copy link
Collaborator Author

eitsupi commented Jul 3, 2023

It might be needed to use a different symbol for each list level: squidfunk.github.io/mkdocs-material/reference/lists/?h=list#usage

I see, thanks for letting me know!

@etiennebacher
Copy link
Collaborator

Note that I'm just guessing, I'll check locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants