Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix use polars without library(polars) #355

Merged
merged 8 commits into from
Aug 8, 2023
Merged

fix use polars without library(polars) #355

merged 8 commits into from
Aug 8, 2023

Conversation

sorhawell
Copy link
Collaborator

@sorhawell sorhawell commented Aug 8, 2023 •
edited
Loading

solves #354

etiennebacher
etiennebacher reviewed Aug 8, 2023
View reviewed changes
DESCRIPTION Outdated Show resolved Hide resolved
@sorhawell
Copy link
Collaborator Author

Maybe I have to upgrade callr to suggests to use it in unit-test.

@etiennebacher
Copy link
Collaborator

I can confirm this works, thanks the quick fix @sorhawell

@etiennebacher etiennebacher merged commit a2c83b9 into main Aug 8, 2023
11 checks passed
@etiennebacher etiennebacher deleted the fix_rust_call_pl branch August 8, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiennebacher etiennebacher etiennebacher approved these changes

@Sicheng-Pan Sicheng-Pan Awaiting requested review from Sicheng-Pan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sorhawell @etiennebacher