Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement $rolling() #470

Merged
merged 14 commits into from
Nov 20, 2023
Merged

Implement $rolling() #470

merged 14 commits into from
Nov 20, 2023

Conversation

etiennebacher
Copy link
Collaborator

@etiennebacher etiennebacher commented Nov 6, 2023 •
edited
Loading

Still WIP:

  • Refactor Rust side (especially ClosedWindow) with Robj to R choice #437 once it is merged
  • Need more tests
  • Complete docs

@etiennebacher etiennebacher mentioned this pull request Nov 8, 2023
Closed
@etiennebacher etiennebacher mentioned this pull request Nov 15, 2023
Closed
@etiennebacher etiennebacher mentioned this pull request Nov 18, 2023
Closed
@etiennebacher etiennebacher marked this pull request as ready for review November 20, 2023 07:19
eitsupi
eitsupi approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

@eitsupi eitsupi merged commit f6af0a7 into main Nov 20, 2023
31 checks passed
@eitsupi eitsupi deleted the implement-rolling branch November 20, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eitsupi eitsupi eitsupi approved these changes

@sorhawell sorhawell Awaiting requested review from sorhawell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etiennebacher @eitsupi