feat: %/%, %% translation and add floor_div, mod, eq_missig and neq_missing
#526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
etiennebacher
approved these changes
Nov 20, 2023
Comment on lines
+1570
to
+1572
| #' pl$col("a")$shift(-2)$alias("shift-2"), | ||
| #' pl$col("a")$shift(2)$alias("shift+2") | ||
| #' ) |
There was a problem hiding this comment.
isn't this indentation wrong? We do want some additional indentation when we are in with_columns() (I guess this is styler's fault)
Same thing for all other changes like this
There was a problem hiding this comment.
Certainly.
We'll probably need to create an issue in the styler repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of functions has been slightly changed in the file for readability.
Note that there is currently a problem with Polars' mod (pola-rs/polars#10570).
(I wasn't sure if I should stop subscribing to
%%because of this problem, but I am anyway)Also note that the function name are different here than in rust-polars (rem v.s. mod) because
modis a reserved word in Rust.Another problem is that py-polars and rust-polars may have different names for these functions.
For these functions r-polars seems to have adopted many of the ones from rust-polars so far, so I'm going to use
floor_divandneq_missinginstead offloordivandne_missingin py-polars.