-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rewrite as_polars_df.data.frame
#817
Conversation
I will update the test and documentation later. @etiennebacher @sorhawell If you are interested, check the performance in the benchmarks above. |
I'll review in more details later, but I'm a bit confused about the objective of this PR. If the speed isn't affected and we don't know if the memory used decreases, then why rewrite this? Is this an intermediate step to fix #676? |
Yes, |
Given the simplicity of the process, it is not surprising that memory usage is reduced. |
Co-authored-by: Etienne Bacher <52219252+etiennebacher@users.noreply.github.com>
Close #816
It used to call
pl$DataFrame
internally, but has been completely rewritten to not call it.Speeds seem to be comparable, but memory usage may have been reduced.
(The
bench
package does not measure memory usage on the Rust side, but given that the output RPolarsDataFrame is the same, memory usage on the Rust side should not be much different.)Created on 2024-02-17 with reprex v2.0.2