Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove some old implementations of methods for Series #844

Merged
merged 3 commits into from
Feb 24, 2024
Merged

refactor: remove some old implementations of methods for Series #844

merged 3 commits into from
Feb 24, 2024

Conversation

etiennebacher
Copy link
Collaborator

Close #839

Also remove some methods for Series since they automatically call Expr methods (followup of #831)

eitsupi
eitsupi approved these changes Feb 24, 2024
View reviewed changes
Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@etiennebacher etiennebacher merged commit a65ae54 into main Feb 24, 2024
1 check passed
@etiennebacher etiennebacher deleted the remove-old-series branch February 24, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eitsupi eitsupi eitsupi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

as.list.Expr is needed?
2 participants
@etiennebacher @eitsupi