Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add a new internal function parse_as_polars_duration_string() #958

Merged
merged 8 commits into from
Mar 27, 2024

Conversation

eitsupi
Copy link
Collaborator

@eitsupi eitsupi commented Mar 21, 2024

The generic function to make it easy to add transformations from other classes.

@eitsupi eitsupi changed the title feat: add a new function parse_as_polars_duration_string() refactor: add and expose a new function parse_as_polars_duration_string() Mar 21, 2024
@eitsupi eitsupi marked this pull request as ready for review March 27, 2024 15:09
@eitsupi eitsupi changed the title refactor: add and expose a new function parse_as_polars_duration_string() refactor: add a new internal function parse_as_polars_duration_string() Mar 27, 2024
Copy link
Collaborator

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@etiennebacher etiennebacher merged commit 2e9b408 into main Mar 27, 2024
26 of 28 checks passed
@etiennebacher etiennebacher deleted the make-duration branch March 27, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants