Remove some deprecated methods and functions

NEWS.md

@@ -49,6 +49,8 @@
 - `$unique()` for `DataFrame` and `LazyFrame` have several changes (#953):
   - New default value `"any"` for argument `keep`.
   - Arguments `keep` and `maintain_order` must be named.
+- The following deprecated methods are now removed: `pl$threadpool_size()`,
+  `<DataFrame>$with_row_count()`, `<LazyFrame>$with_row_count()` (#965).
 
 ### New features
 

R/dataframe__frame.R

@@ -447,13 +447,6 @@ DataFrame_with_row_index = function(name, offset = NULL) {
     unwrap("in $with_row_index():")
 }
 
-DataFrame_with_row_count = function(name, offset = NULL) {
-  warning("`$with_row_count()` is deprecated and will be removed in 0.15.0. Use `with_row_index()` instead.")
-  .pr$DataFrame$with_row_index(self, name, offset) |>
-    unwrap("in $with_row_count():")
-}
-
-
 # define setter function
 DataFrame.property_setters$columns = function(self, names) {
   unwrap(.pr$DataFrame$set_column_names_mut(self, names))
@@ -1010,8 +1003,10 @@ DataFrame_to_list = function(unnest_structs = TRUE, ..., int64_conversion = pola
 DataFrame_join = function(
     other,
     on = NULL,
-    how = c("inner", "left", "outer", "semi", "anti", "cross",
-            "outer_coalesce"),
+    how = c(
+      "inner", "left", "outer", "semi", "anti", "cross",
+      "outer_coalesce"
+    ),
     ...,
     left_on = NULL,
     right_on = NULL,

R/expr__string.R

@@ -4,7 +4,6 @@
 # expr_str_make_sub_ns = macro_new_subnamespace("^ExprStr_", "RPolarsExprStrNameSpace")
 
 
-# TODO for 0.16.0: rename arguments, should not allow positional arguments except for the first two
 #' Convert a String column into a Date/Datetime/Time column.
 #'
 #' Similar to the [strptime()] function.

R/lazyframe__lazy.R

@@ -315,11 +315,6 @@ LazyFrame_with_row_index = function(name, offset = NULL) {
     unwrap("in $with_row_index():")
 }
 
-LazyFrame_with_row_count = function(name, offset = NULL) {
-  warning("`$with_row_count()` is deprecated and will be removed in 0.15.0. Use `with_row_index()` instead.")
-  .pr$LazyFrame$with_row_index(self, name, offset) |>
-    unwrap("in $with_row_count():")
-}
 
 #' Apply filter to LazyFrame
 #'

R/polars_info.R

@@ -107,9 +107,3 @@ check_feature = function(feature_name, context = NULL, call = sys.call(1L)) {
 #' @examples
 #' pl$thread_pool_size()
 pl_thread_pool_size = function() thread_pool_size()
-
-#' @rdname pl_thread_pool_size
-pl_threadpool_size = function() {
-  warning("`pl$threadpool_size()` is deprecated and will be removed in 0.15.0. Use `pl$thread_pool_size()` instead.")
-  thread_pool_size()
-}

tests/testthat/_snaps/after-wrappers.md

@@ -52,9 +52,9 @@
        [93] "std"                       "struct"                   
        [95] "sum"                       "sum_horizontal"           
        [97] "tail"                      "thread_pool_size"         
-       [99] "threadpool_size"           "time"                     
-      [101] "using_string_cache"        "var"                      
-      [103] "when"                      "with_string_cache"        
+       [99] "time"                      "using_string_cache"       
+      [101] "var"                       "when"                     
+      [103] "with_string_cache"        
 
 ---
 
@@ -91,8 +91,8 @@
       [53] "sum"              "tail"             "to_data_frame"    "to_list"         
       [57] "to_series"        "to_struct"        "transpose"        "unique"          
       [61] "unnest"           "var"              "width"            "with_columns"    
-      [65] "with_row_count"   "with_row_index"   "write_csv"        "write_json"      
-      [69] "write_ndjson"     "write_parquet"   
+      [65] "with_row_index"   "write_csv"        "write_json"       "write_ndjson"    
+      [69] "write_parquet"   
 
 ---
 
@@ -164,8 +164,7 @@
       [49] "to_dot"                  "unique"                 
       [51] "unnest"                  "var"                    
       [53] "width"                   "with_columns"           
-      [55] "with_context"            "with_row_count"         
-      [57] "with_row_index"         
+      [55] "with_context"            "with_row_index"         
 
 ---