Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: rewrite <Expr>$bin$decode() and <Expr>$bin$encode() #980

Merged
merged 5 commits into from
Mar 28, 2024
Merged

refactor!: rewrite <Expr>$bin$decode() and <Expr>$bin$encode() #980

merged 5 commits into from
Mar 28, 2024

Conversation

eitsupi
Copy link
Collaborator

@eitsupi eitsupi commented Mar 28, 2024

No description provided.

@eitsupi eitsupi marked this pull request as ready for review March 28, 2024 14:40
@eitsupi eitsupi changed the title refactor!: rewrite <Expr>$bin$decode() refactor!: rewrite <Expr>$bin$decode() and <Expr>$bin$encode() Mar 28, 2024
etiennebacher
etiennebacher approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner indeed, thanks!

@etiennebacher etiennebacher merged commit a3be932 into main Mar 28, 2024
27 of 28 checks passed
@etiennebacher etiennebacher deleted the update-bin-funcs branch March 28, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiennebacher etiennebacher etiennebacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eitsupi @etiennebacher