Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #1077] fix:http 客户端接口鉴权行为保持和gRPC一致 #1076

Merged
merged 5 commits into from
Apr 11, 2023
Merged

[ISSUE #1077] fix:http 客户端接口鉴权行为保持和gRPC一致 #1076

merged 5 commits into from
Apr 11, 2023

Conversation

chuntaojun
Copy link
Member

@chuntaojun chuntaojun commented Apr 11, 2023 •
edited
Loading

Please provide issue(s) of this PR:
Fixes #1077

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • ApiServer
  • Auth
  • Configuration
  • Naming
  • HealthCheck
  • Metrics
  • Docs
  • Installation
  • Performance and Scalability
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@chuntaojun
fix issue polarismesh#629 (polarismesh#693)
65e562a 
* docs:优化错误信息描述

* Update zh.toml

* fix:修复eureka心跳协议错误码不兼容问题

* fix:修复eureka心跳协议错误码不兼容问题

* unit:添加单元测试

* test:调整测试配置文件位置

* fix:issue polarismesh#692

* fix:issue polarismesh#692

* fix:issue polarismesh#692

* fix:issue polarismesh#692
@chuntaojun
docs:add error code desc
668eaac
@chuntaojun
fix:调整license-checker的触发
5327090
@chuntaojun
fix:调整license-checker的触发
77fccd6
@chuntaojun
fix:http 客户端接口鉴权凭据获取
20d96f5
@polaris-test-bot
Copy link

polaris-test-bot commented Apr 11, 2023 •
edited
Loading

2023-04-11 17:21:39: =========TEST START==========
2023-04-11 17:57:04: [STANDALONE VERSION]PR autotest FAILED! We executed 33 test cases and 26 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1308666992/sta/qta-report.html and https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1308666992/sta/ratelimit/qta-report.html
2023-04-11 17:57:09: [CLUSTER VERSION] PR autotest PASSED! We executed 25 test cases and 25 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1308666992/clu/qta-report.html
2023-04-11 17:57:15: [KUBENETES VERSION]PR autotest PASSED! We executed 25 test cases and 25 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1308666992/k8s/qta-report.html

@chuntaojun chuntaojun changed the title fix:http 客户端接口鉴权凭据获取 [ISSUE #1077] fix:http 客户端接口鉴权凭据获取 Apr 11, 2023
andrewshan
andrewshan approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@andrewshan andrewshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chuntaojun chuntaojun changed the title [ISSUE #1077] fix:http 客户端接口鉴权凭据获取 [ISSUE #1077] fix:http 客户端接口鉴权行为保持和gRPC一致 Apr 11, 2023
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #1076 (20d96f5) into main (ea61d50) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1076      +/-   ##
==========================================
+ Coverage   56.56%   56.59%   +0.02%     
==========================================
  Files         182      182              
  Lines       33184    33184              
==========================================
+ Hits        18771    18779       +8     
+ Misses      12028    12022       -6     
+ Partials     2385     2383       -2

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andrewshan andrewshan merged commit dad9aac into polarismesh:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewshan andrewshan andrewshan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP 接入层客户端接口鉴权凭据和 gRPC 接入层实现不一致
3 participants
@chuntaojun @polaris-test-bot @andrewshan