Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #759] feat: 添加 github action #758

Merged
merged 16 commits into from
Oct 20, 2022
Merged

Conversation

chuntaojun
Copy link
Member

@chuntaojun chuntaojun commented Oct 19, 2022

Please provide issue(s) of this PR:
Fixes #759

  • 检查 license 头添加情况
  • 添加 golangci-lint 检查,提前规避代码风格问题

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Configuration
  • Docs
  • Installation
  • Performance and Scalability
  • Naming
  • HealthCheck
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

* docs:优化错误信息描述

* Update zh.toml

* fix:修复eureka心跳协议错误码不兼容问题

* fix:修复eureka心跳协议错误码不兼容问题

* unit:添加单元测试

* test:调整测试配置文件位置

* fix:issue polarismesh#692

* fix:issue polarismesh#692

* fix:issue polarismesh#692

* fix:issue polarismesh#692
@chuntaojun chuntaojun changed the title feat: 添加 github action [ISSUE #759] feat: 添加 github action Oct 19, 2022
Copy link
Member

@daheige daheige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chuntaojun chuntaojun added code quality Prompt code readability, reduce repetitive code, improve code maintainability, code comment github-action github-action labels Oct 20, 2022
@chuntaojun chuntaojun merged commit 0af2fe5 into polarismesh:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Prompt code readability, reduce repetitive code, improve code maintainability, code comment github-action github-action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

添加代码风格检查 & license 标注信息的 github action
3 participants