Fix bug where integration returns no result if the lookup value is not the indicator's primary value #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating Github Actions & Adding config.json
… Machine Readability Creating Release with Dereferenced Symlinks, `polarityIntegrationUuid`, & No Dev Dependencies for Machine Readability
Removing rejectUnauthorized from config files
INT-1129: Fix onDetails lookup for non CVEs
…t the indicator's primary value, and instead alternative value listed
|
@ajung44 Thank you so much for the PR! Can you retarget the PR onto the |
Yep, changed the target to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An Indicator might have multiple file hash values associated with it such as SHA256, MD5, SHA1, etc. However, the indicator's primary value can only be one of them.
If the indicator's primary value is SHA256, and user searched with its MD5 value, the integration returns no result as it fails to match the searched MD5 value. Applied fix to iterate through the associated values to match with the search value instead.