Logictest projections #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asubiotto
reviewed
Nov 29, 2022
| @@ -62,6 +62,8 @@ func (v *astVisitor) leaveImpl(n ast.Node) error { | |||
| v.exprStack[0], | |||
| v.exprStack[1:]..., | |||
| ) | |||
| default: | |||
There was a problem hiding this comment.
Is it correct to have this as the default case? I guess previously we just returned all columns, so we do want to do a Project in all cases, is that right?
There was a problem hiding this comment.
I think we'd want to extend this to support something like select * in the future, but I think for what we have now this is okay?
| return "", fmt.Errorf("createtable: unexpected schema values %v", arg.Vals) | ||
| } | ||
| schema = r.defaultSchema | ||
| schema = r.schemas[arg.Vals[0]] |
There was a problem hiding this comment.
nit: return an error if schema is not found
There was a problem hiding this comment.
We do below where we check if schema is nil
metalmatze
reviewed
Nov 29, 2022
brancz
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Projection support to Logictests as well as adding support for additional schemas.