Add type to ParquetNodeToTypeWithWriterFunc log #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whops yeah you’re right. Would be neat to support float64/doubles though as that’s what promtheus actually uses. Do you want to contribute that? I’ll still merge this so the example that we have works, but would be cool to actually support the “right” type. |
Closed
Yes, but I'm not yet familiar with the code regarding writer. I'll continue reading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing with the sample code and thought it would be easier to debug if the log showed the type of parquet.Node.
I also thought that Int64 was appropriate for the StorageLayout of value in the sample code.