First stage renames, rpc-{core,provider,rx} #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
amaury1093
approved these changes
Oct 9, 2018
|
I just don't like the removed lines/files here. Going to revert those - it needs to be cleaned, but this way is just horrible. (CI needs to do it, otherwise it is just a road to having a hiding down the road) |
ltfschoen
added a commit
that referenced
this pull request
Oct 10, 2018
* Update modulePathIgnorePatterns to match renaming that occurred in PR #220
jacogr
pushed a commit
that referenced
this pull request
Oct 10, 2018
…se in src (#222) * fix: Fixes #221. Exclude tests files in build directory. Only use those in src * See modulePathIgnorePatterns: https://jestjs.io/docs/en/configuration.html#modulepathignorepatterns-array-string * fix: Update modulePathIgnorePatterns to cater for renamed packages * Update modulePathIgnorePatterns to match renaming that occurred in PR #220 * test: Add build directory of api/rx to Jest config of modulePathIgnorePatterns
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Items -
Currently it does not touch api-observable (yet). Still some thinking around that one and the api-* namespace required.