add ChargeAssetTxPayment to SignedExtensions #3668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related to paritytech/cumulus#488 |
jacogr
reviewed
Jun 17, 2021
| import { substrate } from './substrate'; | ||
|
|
||
| // A mapping of the known signed extensions to the extra fields that they contain. Unlike in the actual extensions, | ||
| // we define the extra fields not as a Tuple, but rather as a struct so they can be named. These will be expanded | ||
| // into the various fields when added to the payload (we only support V4 onwards with these, V3 and earlier are | ||
| // deemed fixed and non-changeable) | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment |
There was a problem hiding this comment.
Weird that this is needed, I cannot spot why.
There was a problem hiding this comment.
maybe my vscode picked up a weird default config for eslint?
jacogr
approved these changes
Jun 19, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: not tested, yet.