Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get isEthereum from chain properties #9667

Merged
merged 7 commits into from
Dec 18, 2023

Conversation

fgamundi
Copy link
Contributor

@fgamundi fgamundi commented Jul 6, 2023

Giving the growing number of Ethereum based substrate chains, the Tanssi team is proposing to add isEthereum to the chain properties so apps (such as polkadotjs-apps) can easily distinguish if the chain they're connecting to is Ethereum-based or not without having to maintain and update a manual list.

Depends on polkadot-js/api#5686 & polkadot-js/api#5761

@fgamundi fgamundi marked this pull request as ready for review December 18, 2023 15:46
@fgamundi
Copy link
Contributor Author

@jacogr this should be good to go now that polkadot-js/api#5761 is published :)

@jacogr jacogr merged commit 7c582f0 into polkadot-js:master Dec 18, 2023
5 checks passed
@fgamundi fgamundi deleted the fg-properties-isEthereum branch December 18, 2023 19:36
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants