Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Romaji appears to not work #19

Closed
maemigh opened this issue Jun 30, 2023 · 2 comments
Closed

Romaji appears to not work #19

maemigh opened this issue Jun 30, 2023 · 2 comments

Comments

@maemigh
Copy link

maemigh commented Jun 30, 2023

AttributeError: 'PostalCode' object has no attribute 'romaji'

It looks like there was a section in the README that was removed, but romaji is still in all the examples. The post office actually has a file that includes all the proper romaji, so maybe that could be used?

https://www.post.japanpost.jp/zipcode/dl/roman-zip.html

@maemigh
Copy link
Author

maemigh commented Jun 30, 2023

I saw the actual commit for the removal from a couple years ago. Is the CSV still considered low quality? Not sure what errors you were seeing before.

@polm
Copy link
Owner

polm commented Jul 1, 2023

Thank you for mentioning romaji features were still mentioned in the README, I have removed references to them. As you noted, the functionality was intentionally removed.

The provided romaji are extremely low quality, as outlined in the article introducing posuto - "JA" becomes "JIEIEI", etc. The file was also updated at a separate frequency and hard to sync correctly.

You should use cutlet instead.

@polm polm closed this as completed Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants