Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32.
discrete_y
parameter toestimate_mi()
Simply put, the idea is to modify the distance metric so that the different y values are "infinitely" far apart and therefore don't show up in neighbor searches of other y planes. With sufficiently spaced y, the existing algorithm would produce exactly the same results.
The implementation partitions the space according to y values, using one tree for each y. This reduces the vectorization benefit, but the individual searches are cheaper; by the simple benchmark, this case is faster than the continuous-continuous case.